create rotate file on the fly for access.log - #9324
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9324 +/- ##
=========================================
Coverage 19.72% 19.73%
- Complexity 19941 19945 +4
=========================================
Files 6371 6371
Lines 575738 575738
Branches 70471 70471
=========================================
+ Hits 113582 113606 +24
+ Misses 449810 449784 -26
- Partials 12346 12348 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
c300793 to
f0b45e5
Compare
f0b45e5 to
78a578f
Compare
78a578f to
ff27a44
Compare
|
Hi @DaanHoogland is this PR still in progress? |
|
@nvazquez , it just needs some validation, but should be ready. Outcome of validation might mean adjustment for different platforms, hence it is still in draft. |
There was a problem hiding this comment.
Pull request overview
This PR attempts to ensure the server’s access.log is rotated by generating a logrotate configuration file during embedded server startup (when the Jetty request log is created).
Changes:
- Adds runtime creation of a logrotate config targeting the configured access log file.
- Introduces filesystem write logic under
/etc/logrotate.dfromServerDaemon#createRequestLog().
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@DaanHoogland why aren't we handling logrotate config files in the packaging? That's how it's done typically. |
|
@blueorangutan package |
1 similar comment
|
@blueorangutan package |
asking the question is volunteering! |
ff27a44 to
3e090a5
Compare
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18960 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
@ingox , this was an abandoned PR. I have revived it now. It still needs some functional assessment. As @NuxRo asked, it could be done in packaging as well, an erroneous pattern much applied ;) I am willing to carry this implementation through, if it can get some approval. If not, and the functional ask is still valid, a different tactics must be applied. |
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?